search

stratum-mining / stratumprotocol.org

Website for the Stratum V2 bitcoin mining protocol
https://stratumprotocol.org
MIT License
13 stars 20 forks source link

Improve consistency - `SV2 or Sv2` and `Stratum V2 or Stratum v2` #193

Closed pavlenex closed 5 months ago

pavlenex commented 7 months ago

Once we're done shipping a release, would be great to consolidate how we use Stratum v2 or Stratum V2 ; SV2 or Sv2 since we're inconsistent across website and docs currently.

Requires community discussion on what to settle for. I invite everyone to leave comments on their preference.

It seems specifications are inconsistent about this topic as well.

pavlenex commented 7 months ago

I usually write Stratum v2 and Sv2, so I'd say I'd go with that, though don't think the alternative is a blocker as long as we settle or something.

Sjors commented 7 months ago

I usually write Stratum v2 and Sv2

Same. But maybe that's because I copied it from you :-)

pavlenex commented 7 months ago

I guess specs authors call it Stratum V2 and the opening sentence in specs is Stratum V2, from there it's Stratum v2, sv2 and SV2. So it seems Stratum v2 thus SV2 is how it should be.

Screenshot 2024-02-13 at 19 36 36

Again don't really have hard preference as long as we decide as community and then correct inconsistencies 😄

xyephy commented 5 months ago

Hi @pavlenex is the final conclusion Stratum V2 and SV2? If so, can I start on the cleanup?

pavlenex commented 5 months ago

Hey @xyephy Correct. Go for it.

xyephy commented 5 months ago

@pavlenex I've exempted links and examples from changes i.e 

./bitcoin-sv2-tp-0.1.2/bin/bitcoind -sv2 -sv2port=8442 -sv2interval=20 -sv2feedelta=1000 -debug=sv2 -loglevel=sv2:trace

(roles/sv2/mining-proxy)

https://github.com/stratum-mining/sv2-spec

Also modified a few Sv1 -> SV1 for uniformity

The fix PR: #209