stratum-mining / stratumprotocol.org

Website for the Stratum V2 bitcoin mining protocol
https://stratumprotocol.org
MIT License
13 stars 20 forks source link

When scrolling down the navbar at top hides automatically reopened #215

Open Aashutoshbro opened 5 months ago

Aashutoshbro commented 5 months ago

Issue #200 When scrolling down the navbar at the top should hide automatically

netlify[bot] commented 5 months ago

Deploy Preview for startling-capybara-2231ea ready!

Name Link
Latest commit 461e12f5b2344c3762a14d4320806913916e0082
Latest deploy log https://app.netlify.com/sites/startling-capybara-2231ea/deploys/662e372363b6ed0008acd6f2
Deploy Preview https://deploy-preview-215--startling-capybara-2231ea.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

pavlenex commented 5 months ago

Hey @Aashutoshbro thanks for the PR, what do you think of the menu appearing on the scroll up? It's important imo that we keep the call to actions to important things to the website. Would you be able to add that?

Aashutoshbro commented 5 months ago

@pavlenex It would be great if you could tell me which one (CTA) to include as per the PR, I just made some property change to meet the issue.

pavlenex commented 5 months ago

@Aashutoshbro entire navbar? check this for context https://github.com/stratum-mining/stratumprotocol.org/issues/200#issuecomment-1989124868

Aashutoshbro commented 5 months ago

So it's not actually about making nav hide exactly on scroll up, I guess, It's about making CTA more clear to take action for ease

"I mean yeah, that's the point of the sticky navbar, it's not a bug. It's there so it highlights call to actions clearly."- @pavlenex

pavlenex commented 5 months ago

@Aashutoshbro Hide nav bar on scroll down and show it on scroll up, is that possible?

Aashutoshbro commented 5 months ago

So it's like enhancement to navbar for clear sticky navbar function

can you tell me more about what exactly might me done to go with issue?

Aashutoshbro commented 5 months ago

Can it be achieve with this, you can check this out : @pavlenex src/.vuepress/theme/components/Navbar.vue

(Code line 8) Previous one: hasScrolled ? 'bg-dark-200/90' : 'bg-none '

(Code line 8) Change to: hasScrolled ? 'bg-dark-200/90 hidden' : 'bg-none '

pavlenex commented 5 months ago

If you test these locally and they work, feel free to push them and then we'll have a live preview link build by netlify. Sorry ,not on my pc to test this.

Aashutoshbro commented 5 months ago

Works if the above approach is applied: @pavlenex https://deploy-preview-215--startling-capybara-2231ea.netlify.app/

pavlenex commented 5 months ago

Hey @Aashutoshbro just tested https://deploy-preview-215--startling-capybara-2231ea.netlify.app and header is removed on scroll down, but doesn't re-appear on scroll up

Aashutoshbro commented 5 months ago

Will try to sort that out