stratum / fabric-tna

The SD-Fabric data plane
https://docs.sd-fabric.org/
30 stars 15 forks source link

[SDFAB-798] Refactor physical pipeline and use new ONOS UpfProgrammable #446

Closed daniele-moro closed 2 years ago

daniele-moro commented 2 years ago

This PR implements the PDR/FAR tables refactoring as defined in the design doc.

The new design for the physical pipeline completely removes the concept of PDRs and FARs from the physical pipeline. We introduce instead, uplink/downlink UE sessions, uplink/downlink terminations, and GTP Tunnel Peers (ingress and egress) tables. This new design helps in better scale the number of supported UEs.

Please note that the current indirection based on ue_session doesn’t make much sense, but it’s already prepared for the application filtering.

codecov[bot] commented 2 years ago

Codecov Report

Merging #446 (e415b74) into main (3b059d3) will increase coverage by 0.77%. The diff coverage is 71.37%.

:exclamation: Current head e415b74 differs from pull request most recent head 66f20f7. Consider uploading reports for the commit 66f20f7 to get more accurate results Impacted file tree graph

@@             Coverage Diff              @@
##               main     #446      +/-   ##
============================================
+ Coverage     66.14%   66.92%   +0.77%     
- Complexity      599      618      +19     
============================================
  Files            66       63       -3     
  Lines          4318     4444     +126     
  Branches        463      469       +6     
============================================
+ Hits           2856     2974     +118     
- Misses         1228     1235       +7     
- Partials        234      235       +1     
Impacted Files Coverage Δ
...abric/tna/behaviour/upf/FabricUpfProgrammable.java 53.40% <59.68%> (+4.30%) :arrow_up:
...ric/tna/behaviour/upf/FabricUpfTranslatorUtil.java 50.00% <60.00%> (+1.16%) :arrow_up:
.../fabric/tna/behaviour/upf/FabricUpfTranslator.java 75.46% <78.77%> (+3.16%) :arrow_up:
...oject/fabric/tna/behaviour/FabricCapabilities.java 29.54% <100.00%> (ø)
...mproject/fabric/tna/behaviour/P4InfoConstants.java 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3b059d3...66f20f7. Read the comment docs.

daniele-moro commented 2 years ago

Merging this, the workaround with pa_solitary is being tracked in SDFAB-900.