search

stratum / fabric-tna

The SD-Fabric data plane
https://docs.sd-fabric.org/
30 stars 15 forks source link

Fix license #477

Closed Yi-Tseng closed 2 years ago

charlesmcchan commented 2 years ago

Why didn't reuse lint capture them 🤔

Yi-Tseng commented 2 years ago

Why didn't reuse lint capture them 🤔

We forgot to merge the latest main branch to the license patch. So it didn't check new files

codecov[bot] commented 2 years ago

Codecov Report

Merging #477 (587fa69) into main (58d1e2b) will not change coverage. The diff coverage is n/a.

:exclamation: Current head 587fa69 differs from pull request most recent head c1d44f1. Consider uploading reports for the commit c1d44f1 to get more accurate results

Impacted file tree graph

@@            Coverage Diff            @@
##               main     #477   +/-   ##
=========================================
  Coverage     69.35%   69.35%           
+ Complexity      697      696    -1     
=========================================
  Files            63       63           
  Lines          4634     4634           
  Branches        503      503           
=========================================
  Hits           3214     3214           
  Misses         1158     1158           
  Partials        262      262
Impacted Files Coverage Δ
...ct/fabric/tna/slicing/cli/AbstractFlowCommand.java 0.00% <ø> (ø)
...oject/fabric/tna/slicing/cli/SliceIdCompleter.java 0.00% <ø> (ø)
.../fabric/tna/slicing/cli/TrafficClassCompleter.java 0.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 58d1e2b...c1d44f1. Read the comment docs.

Yi-Tseng commented 2 years ago

retest this please

ccascone commented 2 years ago

Ah, my bad... thanks @Yi-Tseng ! Should d656856 be here?

Yi-Tseng commented 2 years ago

Ah, my bad... thanks @Yi-Tseng ! Should d656856 be here?

Actually, I should create another PR for this fix, but I think I need to fix every INT tests I think I can remove the INT test fix and put skip-ci for this PR and we can just merge it directly

Yi-Tseng commented 2 years ago

retest this please