stratum / fabric-tna

The SD-Fabric data plane
https://docs.sd-fabric.org/
31 stars 15 forks source link

Hardcode BMv2 CPU port in constants #484

Closed daniele-moro closed 2 years ago

daniele-moro commented 2 years ago

Since we don't support P4Runtime translation in bmv2, we can't use the same CPU port in Tofino and bmv2 because it won't fit in the 9 bits used for PortId_t in bmv2.

codecov[bot] commented 2 years ago

Codecov Report

Merging #484 (6a07fd6) into main (6964a9a) will not change coverage. The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##               main     #484   +/-   ##
=========================================
  Coverage     69.90%   69.90%           
  Complexity      722      722           
=========================================
  Files            63       63           
  Lines          4748     4748           
  Branches        523      523           
=========================================
  Hits           3319     3319           
  Misses         1157     1157           
  Partials        272      272           
Impacted Files Coverage Δ
.../java/org/stratumproject/fabric/tna/Constants.java 100.00% <ø> (ø)
...oject/fabric/tna/behaviour/FabricCapabilities.java 40.74% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6964a9a...6a07fd6. Read the comment docs.