search

stratum / fabric-tna

The SD-Fabric data plane
https://docs.sd-fabric.org/
31 stars 15 forks source link

[SDFAB-1022] Add linerate tests for color-aware meters #487

Closed daniele-moro closed 2 years ago

daniele-moro commented 2 years ago

Add a new set of linerate tests to verify the behavior of color-aware meters added in https://github.com/stratum/fabric-tna/pull/474.

Needs to be merged together with: https://gerrit.onosproject.org/c/ci-management/+/25311

codecov[bot] commented 2 years ago

Codecov Report

Merging #487 (91f6d61) into main (a3348fd) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##               main     #487   +/-   ##
=========================================
  Coverage     69.85%   69.85%           
  Complexity      727      727           
=========================================
  Files            63       63           
  Lines          4754     4754           
  Branches        527      527           
=========================================
  Hits           3321     3321           
  Misses         1158     1158           
  Partials        275      275

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a3348fd...91f6d61. Read the comment docs.

daniele-moro commented 2 years ago

@ccascone I addressed most of the comments. I have some doubts about RX rates and especially around fairness.