search

stratum / fabric-tna

The SD-Fabric data plane
https://docs.sd-fabric.org/
31 stars 15 forks source link

Fix meter linerate tests #491

Closed daniele-moro closed 2 years ago

daniele-moro commented 2 years ago

On a run of meter linerate tests, we noticed that removing the first sample from live statistics is not enough to get the TX/RX rate at the regime. For this reason, we remove the first and last 2 samples if we have enough, otherwise we consider all samples in the live stats. Since all linerate meter tests last 10 seconds, and samples are captured every 1 second, we should have enough sample to remove first and last 2. Also, extending monitor_port_stats to pass also the list of ports.

codecov[bot] commented 2 years ago

Codecov Report

Merging #491 (459b888) into main (9ef829e) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##               main     #491   +/-   ##
=========================================
  Coverage     69.85%   69.85%           
  Complexity      727      727           
=========================================
  Files            63       63           
  Lines          4754     4754           
  Branches        527      527           
=========================================
  Hits           3321     3321           
  Misses         1158     1158           
  Partials        275      275

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9ef829e...459b888. Read the comment docs.