search

stratum / fabric-tna

The SD-Fabric data plane
https://docs.sd-fabric.org/
31 stars 15 forks source link

Set GnmiControllerImpl property when loading the pipeconf #496

Closed Yi-Tseng closed 2 years ago

Yi-Tseng commented 2 years ago

The property readPortId is pipeline/pipeconf specific. We can set it when loading the fabric-tna pipeconf.

Yi-Tseng commented 2 years ago

fyi - https://gerrit.onosproject.org/c/onos/+/25319. The property is now in GnmiControllerImpl

sdn@root > cfg get org.onosproject.gnmi.ctl.GnmiControllerImpl
org.onosproject.gnmi.ctl.GnmiControllerImpl
    name=readPortId, type=boolean, value=true, defaultValue=false, description=Configure read port-id for gnmi drivers; default is false.

Got it, will change this

Yi-Tseng commented 2 years ago

retest this please

codecov[bot] commented 2 years ago

Codecov Report

Merging #496 (e483eda) into main (590b2f4) will decrease coverage by 0.01%. The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #496      +/-   ##
============================================
- Coverage     69.85%   69.84%   -0.02%     
  Complexity      727      727              
============================================
  Files            63       63              
  Lines          4754     4755       +1     
  Branches        527      527              
============================================
  Hits           3321     3321              
- Misses         1158     1159       +1     
  Partials        275      275
Impacted Files Coverage Δ
.../org/stratumproject/fabric/tna/PipeconfLoader.java 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 590b2f4...e483eda. Read the comment docs.