stratum / fabric-tna

The SD-Fabric data plane
https://docs.sd-fabric.org/
31 stars 15 forks source link

[SDFAB-1100] Leverage in-order FlowRuleService APIs #512

Closed pierventre closed 2 years ago

pierventre commented 2 years ago

FabricUpfProgrammable leverages the new APIs to guarantee in-order processing of the requests coming from the north.

If batch APIs are not used there is no guarantee about the processing order in the FlowRuleService. Instead, the striped API allow the apps to signal a preference in the requests processing which is used by the FlowRuleService to serialize all the requests, having equal key, on the same executor.

Depends on https://gerrit.onosproject.org/c/onos/+/25423

codecov[bot] commented 2 years ago

Codecov Report

Merging #512 (08d9e80) into main (2e63f6d) will decrease coverage by 0.03%. The diff coverage is 71.42%.

@@             Coverage Diff              @@
##               main     #512      +/-   ##
============================================
- Coverage     69.96%   69.92%   -0.04%     
+ Complexity      740      739       -1     
============================================
  Files            63       63              
  Lines          4801     4802       +1     
  Branches        530      530              
============================================
- Hits           3359     3358       -1     
- Misses         1164     1165       +1     
- Partials        278      279       +1     
Impacted Files Coverage Δ
...abric/tna/behaviour/upf/FabricUpfProgrammable.java 62.14% <71.42%> (-0.12%) :arrow_down:
...atumproject/fabric/tna/stats/StatisticDataKey.java 96.55% <0.00%> (-3.45%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2e63f6d...08d9e80. Read the comment docs.

ccascone commented 2 years ago

Only codecov failed. Merging anyways since the diff with the main branch is negligible (-0.04%).