search

stratum / fabric-tna

The SD-Fabric data plane
https://docs.sd-fabric.org/
31 stars 15 forks source link

[SDFAB-1180] Allow to build fabric-tna when behind proxy #518

Closed daniele-moro closed 2 years ago

daniele-moro commented 2 years ago

@pierventre @charlesmcchan @ccascone What do you prefer, this option or the one in UP4 (see: https://github.com/omec-project/up4/pull/278)?

pierventre commented 2 years ago

no strong preference, they work both to me. My eyes tend to prefer this one though.

codecov[bot] commented 2 years ago

Codecov Report

Merging #518 (d190e30) into main (a33fb69) will not change coverage. The diff coverage is n/a.

:exclamation: Current head d190e30 differs from pull request most recent head 57d6424. Consider uploading reports for the commit 57d6424 to get more accurate results

@@            Coverage Diff            @@
##               main     #518   +/-   ##
=========================================
  Coverage     69.92%   69.92%           
+ Complexity      739      738    -1     
=========================================
  Files            63       63           
  Lines          4802     4802           
  Branches        530      530           
=========================================
  Hits           3358     3358           
  Misses         1165     1165           
  Partials        279      279

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a33fb69...57d6424. Read the comment docs.