Find ways to detect P4 compiler optimized out fields as pre/post-merge check

stratum / fabric-tna

The SD-Fabric data plane

https://docs.sd-fabric.org/

30 stars 15 forks source link

Find ways to detect P4 compiler optimized out fields as pre/post-merge check #96

Closed ccascone closed 3 years ago

ccascone commented 3 years ago

For example:

running integration tests with ONOS and checking for errors like #95 in the ONOS or Stratum log
automatically generate PTF write & read tests for all tables and all actions (based on p4info)

ccascone commented 3 years ago

We decided to go with the PTF approach

pudelkoM commented 3 years ago

Hard disagree on the pre/post-commit part. Running the ptf tests against tofino model takes at least 5min. And there is no way to make use everyone runs these locally. This clearly belongs into the CI pipeline.

pudelkoM commented 3 years ago

I wonder if this is applicable to a wider range of projects, and thus could be a standalone tool.

Part of normal PTF tests:

+ Don't have to care about setup, mastership, ...
+ Run automatically as part of usual tests
- Can't reuse in other projects

Tool that generates testvectors from p4info:

+ Don't have to care about setup, mastership, ...
+ Need to add a new CI step/job
+ Reusable

Completely standalone tool:

- Have to re-implement P4RT setup and handling
+ Reusable