search

stratumn / go-core

Stratumn's core utilities to create decentralized applications and networks
Apache License 2.0
0 stars 0 forks source link

fossilizerhttp: use JSON instead of form data #473

Closed t-bast closed 6 years ago

t-bast commented 6 years ago

This is breaking change, when Trace updates it go-core dependency it should make a change in its client code as well (maybe use js-core?).

This change is Reviewable

simonvadee commented 6 years ago

fossilizer/fossilizerhttp/fossilizerhttp.go, line 206 at r1 (raw file):

Previously, golangcibot (Bot from GolangCI) wrote…
struct field tag `json="data"` not compatible with reflect.StructTag.Get: bad syntax for struct tag pair

good catch mate

codecov[bot] commented 6 years ago

Codecov Report

Merging #473 into master will decrease coverage by 0.06%. The diff coverage is 90%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #473      +/-   ##
==========================================
- Coverage   70.38%   70.31%   -0.07%     
==========================================
  Files          90       90              
  Lines        5325     5326       +1     
==========================================
- Hits         3748     3745       -3     
- Misses       1204     1208       +4     
  Partials      373      373
Impacted Files Coverage Δ
fossilizer/fossilizerhttp/fossilizerhttp.go 82.95% <90%> (+2.49%) :arrow_up:
batchfossilizer/batchfossilizer.go 74.18% <0%> (-2.46%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9c90836...5fc6822. Read the comment docs.