stravo1 / obsidian-gdrive-sync

sync notes across devices in Obsidian via Google Drive
519 stars 15 forks source link

A pop up saying something about my data being synced pops up and interrupts my typing when In a table #45

Open Enderform3 opened 1 month ago

Enderform3 commented 1 month ago

I hope this gets fixed, because it can be annoying if you have your refresh time at default.

stravo1 commented 1 month ago

if you're talking about the "... has been externally modified, merging changes automatically" popup then unfortunately can't do much about it. you can type faster or increase the refresh time to reduce it's occurrence but that's it. although it's a cosmetic issue, should not affect typing or syncing.

what do you mean by interrupting? it shouldn't really interrupt your typing.

somogyi-ede commented 1 month ago

I'm having the same issue and I can confirm that it takes focus away from what you're typing whenever the message pops up. I installed your plugin on Windows, macOS and Android and the issue occurs even if I don't have any other instances of Obsidian open on any of my other devices. Unfortunately it's not a solely cosmetic issue.

Update: it seems to take focus away when typing in a table cell, focus is not lost when typing outside a table (that I noticed). Also, it seems to be from the syncing and not the popup, as focus is lost even when the popup doesn't show up (again, when writing into a table).

stravo1 commented 1 month ago

yes, i have noticed it on tables, even sometimes for Latex expressions it takes away focus. unfortunately i don't know how to solve it. but for normal texts it's fine.

stravo1 commented 1 month ago

https://github.com/user-attachments/assets/61ef7bd1-99b1-4901-983f-dcdb74539030

somogyi-ede commented 1 month ago

Yes, I've been working with tables lately and I noticed this behavior when writing to a table -- regular typing is indeed not affected, as your video suggests.

The focus loss inside tables definitely has something to do with the syncing interval though. I set it to a minute and the issue was gone, but only for a minute.

There seem to be two separate, but related issues here. I did some more testing and found that both the popup and the syncing take the focus away:

Syncing by itself, no popup:

https://github.com/user-attachments/assets/4926a80c-bcd2-4616-8b5c-5ac35e9e072f

Popup, interrupting typing:

https://github.com/user-attachments/assets/00d2c37f-2f37-4a6e-8951-d3c3fcab9ab2

stravo1 commented 1 month ago

the pop up comes while the sync tries to refresh the content while you are typing, so the losing of focus during pop up is a subset of the main issue where the lose of focus happens during the sync as the pop up comes during sync only.

stravo1 commented 1 month ago

most probably it is out of my control but as you suggested increasing the refresh time should help

somogyi-ede commented 1 month ago

Unfortunately this is going to be a dealbreaker for a lot of people, which is a shame, as it's a useful little plugin. Increasing the sync interval is not really a solution as it's rather inconvenient (you may lose work if you set it too high and quit Obsidian without waiting out those X seconds) and it doesn't help with the popup taking focus away (as opposed to the syncing mechanism where there's no popup, see above). Even with the sync interval set to a higher number the popup appears more frequently. Please, if you can, take a look and see if there's anything that can be done on your end. Do we know if the same thing occurs with Obsidian's own sync?

stravo1 commented 1 month ago

will try my best to figure something out, thanks for the detailed reporting.

updates are announced in the discord server. also i need testers for testing new features. so if you don't mind please do join the discord server.

somogyi-ede commented 1 month ago

Sure, let me join. Thanks!

stravo1 commented 1 month ago

https://discord.com/invite/dPasX4Ac2P

Enderform3 commented 1 month ago

will try my best to figure something out, thanks for the detailed reporting.

updates are announced in the discord server. also i need testers for testing new features. so if you don't mind please do join the discord server.

thanks for responding! Maybe use some kind of log in the properties to see if the file was written from the current device and not update the information on the page currently being written. This would either solve the problem, or make it slightly less annoying.