Closed zvyn closed 10 months ago
This had the side-effect of turning a datetime object into a date object in an otherwise unrelated test.
Oh, I know what happened. The field is a DateField
, but the argument was typed as datetime
. It is actually a bug in the test that your change identified because you called .full_clean()
on the model.
It is harmless though and I'll fix it later :)
@zvyn there's just a small pyright issue that needs to be fixed, then it can be merged
@bellini666 thanks for the review! I'll take a look at the pyright issue later today
Patch coverage: 66.66%
and no project coverage change.
Comparison is base (
2a2723c
) 87.99% compared to head (5bcdebf
) 87.99%. Report is 2 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Description
Extends the
OperationMessage
by acode
attribute that is set to theValidationError.code
if available.I changed the test project to apply Djangos default validation in order to test that error codes used by Django internally are passed through as expected. This had the side-effect of turning a
datetime
object into adate
object in an otherwise unrelated test.Types of Changes
Issues Fixed or Closed by This PR
356
Checklist