FIX: DEBUG_TOOLBAR_CONFIG["SHOW_TOOLBAR_CALLBACK"] is not taken into … - Githubissues

strawberry-graphql / strawberry-django

Strawberry GraphQL Django extension

MIT License

394 stars 115 forks source link

FIX: DEBUG_TOOLBAR_CONFIG["SHOW_TOOLBAR_CALLBACK"] is not taken into … #367

Closed sergio-bershadsky closed 9 months ago

sergio-bershadsky commented 10 months ago

Fixes issue associated with SHOW_TOOLBAR_CALLBACK settings

Description

Types of Changes

[x] Core
[x] Bugfix
[ ] New feature
[ ] Enhancement/optimization
[ ] Documentation

Issues Fixed or Closed by This PR

Fix #366

Checklist

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[x] I have tested the changes and verified that they work and don't break anything (as well as I can manage).

bellini666 commented 10 months ago

Hi @sergio-bershadsky ,

Thank you! :)

The PR seems fine, just need to take a look at the pyright issues in it, after that it can be merged

bellini666 commented 9 months ago

This has been superseded by https://github.com/strawberry-graphql/strawberry-graphql-django/pull/384