Closed sdobbelaere closed 8 months ago
Attention: 19 lines
in your changes are missing coverage. Please review.
Comparison is base (
25e3ca2
) 87.46% compared to head (82f9e07
) 87.04%. Report is 4 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
It would seem that login and logout mutations were also non compatible with ASGI/websockets. This was addressed by using the channels authentication rather then the default django.
It would seem that login and logout mutations were also non compatible with ASGI/websockets. This was addressed by using the channels authentication rather then the default django.
@bellini666 Not sure if you need anything else from mee on this pull-request? All tests seem to be passing.
Sorry for not replying earlier to this.
No problem :)
I was out during last week for the djangocon event (I was a speaker there https://2023.djangocon.us/talks/building-high-performance-type-safe-graphql-apis-with-strawberry-and-django/).
Nice! Some publicity for the library is a good idea indeed!
I made a small suggestion regarding the
logout
that you pointed out. If you want to fix it, I'll merge it after. Otherwise just tell me and this is fine to be merged already
Yes, I'll take a look. I hope it's a detail, but I fear that logout function may not work as advertised otherwise the login wouldn't work - which it does.
Logout mutation seems to be working fine. Excess line removed.
All done. Ready for merge from my end @bellini666
The context object can turn into a dict when using ASGI. This pull requests accounts for both ASGI and WSGI conditions and replaces the use of
info.context.request
withget_request(info)