strawberry-graphql / strawberry-django

Strawberry GraphQL Django extension
MIT License
393 stars 115 forks source link

fix: keep ordering sequence #409

Closed bellini666 closed 8 months ago

bellini666 commented 8 months ago

Make sure that the sequence the ordering was given by the client is respected.

Fix #150

codecov-commenter commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (e336ebe) 87.04% compared to head (bbcd437) 87.11%. Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #409 +/- ## ========================================== + Coverage 87.04% 87.11% +0.07% ========================================== Files 36 36 Lines 3056 3074 +18 ========================================== + Hits 2660 2678 +18 Misses 396 396 ``` | [Files](https://app.codecov.io/gh/strawberry-graphql/strawberry-graphql-django/pull/409?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=strawberry-graphql) | Coverage Δ | | |---|---|---| | [strawberry\_django/fields/field.py](https://app.codecov.io/gh/strawberry-graphql/strawberry-graphql-django/pull/409?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=strawberry-graphql#diff-c3RyYXdiZXJyeV9kamFuZ28vZmllbGRzL2ZpZWxkLnB5) | `96.98% <100.00%> (ø)` | | | [strawberry\_django/filters.py](https://app.codecov.io/gh/strawberry-graphql/strawberry-graphql-django/pull/409?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=strawberry-graphql#diff-c3RyYXdiZXJyeV9kamFuZ28vZmlsdGVycy5weQ==) | `97.80% <100.00%> (+0.01%)` | :arrow_up: | | [strawberry\_django/ordering.py](https://app.codecov.io/gh/strawberry-graphql/strawberry-graphql-django/pull/409?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=strawberry-graphql#diff-c3RyYXdiZXJyeV9kamFuZ28vb3JkZXJpbmcucHk=) | `97.05% <100.00%> (+0.58%)` | :arrow_up: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.