Closed yergom closed 4 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
5c999e9
) 87.90% compared to head (a4cc6a7
) 87.90%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Only 1 subtype of an interface types (e.g Node) is optimized. This PR fixes the optimizer's
`_interfaces
cache, so that all interfaces are considered for optimization. I assume that the cache was introduced to avoid a performance hit (having to iterate over all the schema's types) every time an interface has to be optimized.Before this PR, the following would happen. Suppose that we have A and B, both implementing the Node interface:
_interfaces
cache is empty. The optimizer will add to the_interfaces
cache only A, which will get all the optimization hints_interfaces
cache contains only A. The optimizer will fail to optimize B.Types of Changes
Checklist