strawberry-graphql / strawberry-django

Strawberry GraphQL Django extension
MIT License
391 stars 115 forks source link

Fix permissioned pagination #480

Closed vecchp closed 4 months ago

vecchp commented 4 months ago

Fixes an error when trying to apply permission checks using the HasRetvalPerm extension on a paginated list.

TypeError: Cannot filter a query once a slice has been taken.

Types of Changes

Issues Fixed or Closed by This PR

Fix https://github.com/strawberry-graphql/strawberry-django/issues/471

Checklist

codecov-commenter commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (94830a1) 87.90% compared to head (ccb8d77) 87.90%. Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #480 +/- ## ======================================= Coverage 87.90% 87.90% ======================================= Files 37 37 Lines 3167 3167 ======================================= Hits 2784 2784 Misses 383 383 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.