search

strawberry-graphql / strawberry-django

Strawberry GraphQL Django extension
MIT License
391 stars 115 forks source link

fix: fix issues when using pagination together with HasRetvalPerm #482

Closed bellini666 closed 4 months ago

bellini666 commented 4 months ago

Fix #471

codecov-commenter commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (521397c) 87.90% compared to head (1ccf906) 87.92%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #482 +/- ## ========================================== + Coverage 87.90% 87.92% +0.02% ========================================== Files 37 37 Lines 3167 3173 +6 ========================================== + Hits 2784 2790 +6 Misses 383 383 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

bellini666 commented 4 months ago

Just noticed there's a PR fixing the same issue: https://github.com/strawberry-graphql/strawberry-django/pull/480

Closing this as I liked the approach there even more