fix: Fix nested pagination/filtering/ordering not working when "only optimization" is disabled - Githubissues

strawberry-graphql / strawberry-django

Strawberry GraphQL Django extension

https://strawberry.rocks/docs/django

MIT License

421 stars 123 forks source link

fix: Fix nested pagination/filtering/ordering not working when "only optimization" is disabled #569

Closed aprams closed 5 months ago

aprams commented 5 months ago

Description

Types of Changes

[ ] Core
[ ] Bugfix
[ ] New feature
[ ] Enhancement/optimization
[ ] Documentation

Issues Fixed or Closed by This PR

Fix https://github.com/strawberry-graphql/strawberry-django/issues/563

Checklist

[ ] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[ ] I have tested the changes and verified that they work and don't break anything (as well as I can manage).

bellini666 commented 5 months ago

Thanks @aprams :)

I think I found the issue, going to use this PR to send the fix

aprams commented 5 months ago

@bellini666 this worked! 🚀 You rock 🪨