strawberry-graphql / strawberry-django

Strawberry GraphQL Django extension
https://strawberry.rocks/docs/django
MIT License
421 stars 122 forks source link

docs: Remove mention about having to enable subscriptions in the docs #645

Closed bellini666 closed 1 month ago

bellini666 commented 1 month ago

The subscriptions feature is now enabled by default.

Not only that, but the keyword to enable it got removed in https://github.com/strawberry-graphql/strawberry/releases/tag/0.245.0

Fix #644

Summary by Sourcery

Documentation:

sourcery-ai[bot] commented 1 month ago

Reviewer's Guide by Sourcery

This pull request removes outdated information from the documentation regarding the need to enable subscriptions, as the feature is now enabled by default.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Remove instructions for enabling subscriptions in Django URLs
  • Delete code snippet showing how to enable subscriptions in AsgiGraphQLView
  • Remove explanation about enabling subscriptions in MyProject.urls.py
docs/guide/subscriptions.md

Possibly linked issues


Tips and commands #### Interacting with Sourcery - **Trigger a new review:** Comment `@sourcery-ai review` on the pull request. - **Continue discussions:** Reply directly to Sourcery's review comments. - **Generate a GitHub issue from a review comment:** Ask Sourcery to create an issue from a review comment by replying to it. - **Generate a pull request title:** Write `@sourcery-ai` anywhere in the pull request title to generate a title at any time. - **Generate a pull request summary:** Write `@sourcery-ai summary` anywhere in the pull request body to generate a PR summary at any time. You can also use this command to specify where the summary should be inserted. #### Customizing Your Experience Access your [dashboard](https://app.sourcery.ai) to: - Enable or disable review features such as the Sourcery-generated pull request summary, the reviewer's guide, and others. - Change the review language. - Add, remove or edit custom review instructions. - Adjust other review settings. #### Getting Help - [Contact our support team](mailto:support@sourcery.ai) for questions or feedback. - Visit our [documentation](https://docs.sourcery.ai) for detailed guides and information. - Keep in touch with the Sourcery team by following us on [X/Twitter](https://x.com/SourceryAI), [LinkedIn](https://www.linkedin.com/company/sourcery-ai/) or [GitHub](https://github.com/sourcery-ai).
codecov-commenter commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 88.71%. Comparing base (5ff6250) to head (5c2b20c).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #645 +/- ## ======================================= Coverage 88.71% 88.71% ======================================= Files 41 41 Lines 3606 3606 ======================================= Hits 3199 3199 Misses 407 407 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.