strawberry-graphql / strawberry-sqlalchemy

A SQLAlchemy Integration for strawberry-graphql
MIT License
93 stars 27 forks source link

refactor!: map BigInteger to new BigInt scalar #101

Closed IdoKendo closed 10 months ago

IdoKendo commented 11 months ago

This PR fixes #100 by implementing a new custom scalar Int64 following the strawberry documentation: https://strawberry.rocks/docs/types/scalars#int64

Description

The new Int64 custom scalar resolved issues of very large integers when using SQLAlchemy's BigInteger.

Types of Changes

Issues Fixed or Closed by This PR

Checklist

botberry commented 11 months ago

Thanks for adding the RELEASE.md file!

Here's a preview of the changelog:


This change implements a new custom scalar BigInt that is mapped to SQLAlchemy's BigInteger.

erikwrede commented 11 months ago

Thanks for the quick PR! I adjusted the title since this is a breaking change if we're strict. Still want to wait on a second opinion from @mattalbr but for me this is ready to merge. Since we don't have any unit tests on the scalar conversion yet, this is fine for me 😊

botberry commented 10 months ago

Thanks for contributing to Strawberry! 🎉 You've been invited to join the Strawberry GraphQL organisation 😊

You can also request a free sticker by filling this form: https://forms.gle/dmnfQUPoY5gZbVT67

And don't forget to join our discord server: https://strawberry.rocks/discord 🔥