strawberry-graphql / strawberry-sqlalchemy

A SQLAlchemy Integration for strawberry-graphql
MIT License
91 stars 26 forks source link

Future of this integration #180

Open patrick91 opened 3 months ago

patrick91 commented 3 months ago

Hi folks!

I wanted to write something I was discussing with @bellini666 a few weeks ago, at the moment we don't really have a maintainer for this library, I think @mattalbr is quite busy with his work, so we were wondering if we need to do a call for maintainers (if you, reading this, are interested let us know!)

Additionally we were thinking about how we can converge the integrations a bit, Strawberry Django has a lot of features that can be reuse/reimplemented here, but I think some of the APIs are different, maybe there's an opportunity to update this library to have a similar API to strawberry django (of course trying to prevent breaking changes if possible)

What do you think? /cc @erikwrede

Upvote & Fund

Fund with Polar

bellini666 commented 3 months ago

Additionally we were thinking about how we can converge the integrations a bit, Strawberry Django has a lot of features that can be reuse/reimplemented here, but I think some of the APIs are different, maybe there's an opportunity to update this library to have a similar API to strawberry django (of course trying to prevent breaking changes if possible)

Would love to move the "agnostic" pieces of strawberry django to strawberry itself, which could benefit not only this integration, but maybe pydantic's as well and others to come

Philaeux commented 1 month ago

What are the options for someone using SQLAlchemy and Strawberry? To my knowledge:

Are there any other way?

Ckk3 commented 4 weeks ago

Hi folks!

I wanted to write something I was discussing with @bellini666 a few weeks ago, at the moment we don't really have a maintainer for this library, I think @mattalbr is quite busy with his work, so we were wondering if we need to do a call for maintainers (if you, reading this, are interested let us know!)

Additionally we were thinking about how we can converge the integrations a bit, Strawberry Django has a lot of features that can be reuse/reimplemented here, but I think some of the APIs are different, maybe there's an opportunity to update this library to have a similar API to strawberry django (of course trying to prevent breaking changes if possible)

What do you think? /cc @erikwrede

Upvote & Fund

  • We're using Polar.sh so you can upvote and help fund this issue.
  • We receive the funding once the issue is completed & confirmed by you.
  • Thank you in advance for helping prioritize & fund our backlog.

Fund with Polar

Hi, I can dedicate some time of my week to work on this library as a maintainer, I already have some contributions to this project. I'm currently a mid-level django developer, if its is okay, please fell free to contact me! I'm already on discord server as @gustavom0ta

bellini666 commented 1 week ago

@Ckk3 hey :)

Sorry for taking long to comment here. We indeed would appreciate some help with this lib. Let's chat! :)

Ping me on Discord. If sending a PM you can speak Portuguese with me, I'm also Brazilian 😊

Ckk3 commented 1 week ago

@Ckk3 hey :)

Sorry for taking long to comment here. We indeed would appreciate some help with this lib. Let's chat! :)

Ping me on Discord. If sending a PM you can speak Portuguese with me, I'm also Brazilian 😊

Hi! It's okay don't worry, I'm gonna send a friend request to you!

mattalbr commented 2 days ago

Hi all, sorry, I have indeed been completely MIA. It's awesome to see all the interest shown here to keep this library going.

Patrick correctly guessed that I've been extremely busy, and I won't have a ton of cycles to devote here, but I'd like to contribute where I can to keep this project moving forward in a good direction.

For now, as the absolute bare minimum, I sent out a PR to unblock upgrading strawberry. I think it's probably blocked on @Ckk3 's PR fixing our CI

I'll also make sure emails for this repo get properly sent to my work email, where I'm much more responsive than my personal email.