Closed mattalbr closed 1 month ago
This pull request updates the codebase to accommodate changes in the Strawberry library's type organization. The changes are primarily import path updates and minor adjustments to how Strawberry's internal structures are accessed, with no functional changes to the application logic.
No sequence diagrams generated as the changes look simple and do not need a visual representation.
Change | Details | Files |
---|---|---|
Update access to Strawberry's internal structures |
|
tests/test_mapper.py |
Modify BigInt scalar definition |
|
src/strawberry_sqlalchemy_mapper/scalars.py |
Update import path for Strawberry types |
|
src/strawberry_sqlalchemy_mapper/relay.py |
Hi, thanks for contributing to Strawberry 🍓!
We noticed that this PR is missing a RELEASE.md
file. We use that to automatically do releases here on GitHub and, most importantly, to PyPI!
So as soon as this PR is merged, a release will be made 🚀.
Here's an example of RELEASE.md
:
Release type: patch
Description of the changes, ideally with some examples, if adding a new feature.
Release type can be one of patch, minor or major. We use semver, so make sure to pick the appropriate type. If in doubt feel free to ask :)
Comparing mattalbr:upgrade_strawberry
(2974a3c) with main
(f9c09a1)
âś… 1
untouched benchmarks
Hi @mattalbr, I noticed that this PR seems to duplicate the work in #187. It wasn’t immediately clear because the first PR was opened before the issue, so the issue came up without a linked PR.
Since you have more experience with this project, what do you think is the best course of action? Should we prioritize the later PR?
Hi @mattalbr, I noticed that this PR seems to duplicate the work in #187. It wasn’t immediately clear because the first PR was opened before the issue, so the issue came up without a linked PR.
Since you have more experience with this project, what do you think is the best course of action? Should we prioritize the later PR?
Amazing, I missed #187! Assuming the author of #187 is responsive to the few tweaks we need for the latest version, I would definitely prefer we go with their PR! It never feels good to have your PR swooped :)
Closing for now, I'll reopen if we stall on #187.
Strawberry reorganized a lot of its types, so this is just a no-op that changes a bunch of import paths.
Issues Fixed or Closed by This PR
Checklist
Summary by Sourcery
Unblock the upgrade to Strawberry 0.243.1 by updating import paths and adapting to changes in type definitions.
Enhancements: