Fix Interface mapping - Githubissues

strawberry-graphql / strawberry-sqlalchemy

A SQLAlchemy Integration for strawberry-graphql

MIT License

91 stars 26 forks source link

Fix Interface mapping #24

Closed asimov-layton closed 1 year ago

asimov-layton commented 1 year ago

Description

Fixes a bug where an Interface is not properly registered, resulting in an infinite-loop for mapping Interfaces to polymorphic Models.

Changes:

Properly adds Interfaces to mapped_interfaces
Updates deprecated _type_definition references to __strawberry_definition__

Types of Changes

[ ] Core
[x] Bugfix
[ ] New feature
[ ] Enhancement/optimization
[ ] Documentation

Checklist

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[x] I have added tests to cover my changes.
[x] I have tested the changes and verified that they work and don't break anything (as well as I can manage).

mattalbr commented 1 year ago

This looks good to me! Would you mind adding a RELEASE.md file, which should trigger our new automated testing that I think I finally got working in the last few days =) You can ignore the Lint, which I haven't gotten green yet.

Something like:

Release type: patch

Fixes a bug where an Interface is not properly registered, resulting in an infinite-loop for mapping Interfaces to polymorphic Models.

asimov-layton commented 1 year ago

This looks good to me! Would you mind adding a RELEASE.md file, which should trigger our new automated testing that I think I finally got working in the last few days =) You can ignore the Lint, which I haven't gotten green yet.

Something like:
Release type: patch

Fixes a bug where an Interface is not properly registered, resulting in an infinite-loop for mapping Interfaces to polymorphic Models.

Done!

botberry commented 1 year ago

Thanks for adding the RELEASE.md file!

Here's a preview of the changelog:

Fixes a bug where an Interface is not properly registered, resulting in an infinite-loop for mapping Interfaces to polymorphic Models.

codspeed-hq[bot] commented 1 year ago

CodSpeed Performance Report

Merging #24 will not alter performance

_{:warning: No base runs were found}

_{Falling back to comparing AsimovBio:fix-interface-mapping (ab3967d) with main (f3deccd)}

Summary

✅ 1 untouched benchmarks

codecov-commenter commented 1 year ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@b6cf024). Click here to learn what that means. The diff coverage is n/a.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #24 +/- ## ======================================= Coverage ? 77.50% ======================================= Files ? 10 Lines ? 729 Branches ? 106 ======================================= Hits ? 565 Misses ? 135 Partials ? 29 ```

botberry commented 1 year ago

Thanks for contributing to Strawberry! 🎉 You've been invited to join the Strawberry GraphQL organisation 😊

You can also request a free sticker by filling this form: https://forms.gle/dmnfQUPoY5gZbVT67

And don't forget to join our discord server: https://strawberry.rocks/discord 🔥