Implement Standalone Convert; Enum Handling; User Edge/Connection Classes; Column Alias Handling

gravy-jones-locker commented 1 year ago

Description

This includes a number of changes, including:

mapper.type now calls mapper.convert - this allows mapper.convert to be called within user code, which makes the relevant functionality accessible where a decorator is not appropriate.
strawberry.enum is called against SQLAlchemy Enum columns.
Rather than relying on dynamically generated, model specific classes, the user can now pass Edge and Connection classes to the mapper constructor. This is necessary where those Edge/Connection classes are used elsewhere in user schemas.
Relationship mapping is updated such that user-defined column names are taken into account rather than just model attribute names.

*

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[ ] I have tested the changes and verified that they work and don't break anything (as well as I can manage).

Ckk3 commented 1 year ago

up

botberry commented 1 year ago

Hi, thanks for contributing to Strawberry 🍓!

We noticed that this PR is missing a RELEASE.md file. We use that to automatically do releases here on GitHub and, most importantly, to PyPI!

So as soon as this PR is merged, a release will be made 🚀.

Here's an example of RELEASE.md:

Release type: patch

Description of the changes, ideally with some examples, if adding a new feature.

Release type can be one of patch, minor or major. We use semver, so make sure to pick the appropriate type. If in doubt feel free to ask :)

erikwrede commented 3 months ago

Hey, let's delay the enum part of this until we've standardized https://github.com/strawberry-graphql/strawberry/issues/3543 This will allow us to just use any enum and have strawberry's core logic handle the rest.