search

strawberry-graphql / strawberry-sqlalchemy

A SQLAlchemy Integration for strawberry-graphql
MIT License
91 stars 26 forks source link

Make sure async session is still open when we call .all(). #55

Closed mattalbr closed 1 year ago

mattalbr commented 1 year ago

I haven't figured out how to reproduce this in our tests yet, unfortunately, but it fails my company's tests because .all() expects the session in the result identity map to still be open. For now, port the fix while I try to figure out how to repro (possibly would have been caught by the benchmarks I made in a PR elsewhere)

botberry commented 1 year ago

Thanks for adding the RELEASE.md file!

Here's a preview of the changelog:

Make sure async session is still open when we call .all()