Add quotes around Pip extra installs in `README`/docs to support ZSH shells

[ajhynes7]

Hello, I wanted to try out this package but I can't install the extra dependency debug-server.

pip install strawberry-graphql is successful, but pip install strawberry-graphql[debug-server] is not.

❯ pip install strawberry-graphql[debug-server]
zsh: no matches found: strawberry-graphql[debug-server]

Environment

• Python version: 3.10.0 (installed with pyenv)
• OS: Fedora 34
• Shell: zsh

Upvote & Fund

• We're using Polar.sh so you can upvote and help fund this issue.
• We receive the funding once the issue is completed & confirmed by you.
• Thank you in advance for helping prioritize & fund our backlog.

[12306hujunjie]

you can fix it with '' pip install 'strawberry-graphql[debug-server]'

[ajhynes7]

That worked, thanks!

[ajhynes7]

The docs don't have the quotes though, so it's a bit confusing. Do you know why the quotes are needed?

[jkimbo]

@ajhynes7 it's a zsh thing: https://zsh.sourceforge.io/Doc/Release/Expansion.html#Glob-Operators

[patrick91]

@jkimbo shall we add quotes to the docs? Zsh is the default on mac and maybe some linux distros too :)

[jkimbo]

@patrick91 yep we probably should

[jkimbo]

Fixed in #1356

[BryceBeagle]

I'm not sure this is entirely resolved in #1356 because that just updated the README. We still have the docs (on the website) to update

[memark]

@BryceBeagle Well spotted, I'll update them in a separate PR.

There are some example pip installs in CHANGELOG, should I update?

There are some example pip installs in cli/commands/server.py, should I update?

[BryceBeagle]

I wouldn't worry about updating the CHANGELOG

[BryceBeagle]

I'd update the help text in cli/commands/server.py, though

[jkimbo]

I think we've successfully resolved this now.

[ajhynes7]

Ok thank you!