Issue with starlite websockets test - Githubissues

strawberry-graphql / strawberry

A GraphQL library for Python that leverages type annotations 🍓

https://strawberry.rocks

MIT License

4k stars 530 forks source link

Issue with starlite websockets test #2702

Closed kristjanvalur closed 1 month ago

kristjanvalur commented 1 year ago

Just a heads up, there is an issue with the Starlite websockets test client which causes unittests to sometimes hang. This is some issue with starlite itself, because the websocket_connect() method deadlocks if it raises a WebsocketDisconnect.

I'm working on a PR to disable the test in question, and to fix some race conditions regartig websocket connect timeouts.

Describe the Bug

System Information

Operating system:
Strawberry version (if applicable):

Additional Context

Upvote & Fund

We're using Polar.sh so you can upvote and help fund this issue.
We receive the funding once the issue is completed & confirmed by you.
Thank you in advance for helping prioritize & fund our backlog.

Fund with Polar

kristjanvalur commented 1 month ago

I guess this is closed with the merging of 2703