Open patrick91 opened 11 months ago
we could also revisit the PR to add support for descriptions like this:
@strawberry.type
class VehicleFilmsConnection:
"""A connection to a list of items."""
page_info: PageInfo
"Information to aid in pagination."
edges: list[VehicleFilmsEdge | None] | None
"A list of edges."
total_count: int | None
"""
A count of the total number of objects in this connection, ignoring pagination.
This allows a client to fetch the first five objects by passing "5" as the
argument to "first", then fetch the total count so it could display "5 of 83",
for example.
"""
films: list[Film | None] | None
"""
A list of all of the objects returned in the connection. This is a convenience
field provided for quickly exploring the API; rather than querying for
"{ edges { node } }" when no edge data is needed, this field can be be used
instead. Note that when clients like Relay need to fetch the "cursor" field on
the edge to enable efficient pagination, this shortcut cannot be used, and the
full "{ edges { node } }" version should be used instead.
"""
but we would still need to dedent (and support passing description to strawberry.field/type)
Let's say we have this code:
We could allow users to actually write this:
which is quite nicer than what we had before, but it would include the spaces in the outputted schema, but we could run
textwrap.dedent
(plus strip to fix this), what do you think?Upvote & Fund