ci: Try to fix cache failures when running GH actions

bellini666 commented 2 months ago

Make env.pythonLocation as part of the cache key, as suggested by https://github.com/wntrblm/nox/issues/735#issuecomment-1854599576
Remove the generic option from restore cache to avoid the same issues we had before
Use uv as the default venv backend for a performance improvement when installing packages (updated nox for this)
Remove strategy: fail-fast in some places where we are not using matrix, and thus this was not doing anything

Summary by Sourcery

Improve GitHub Actions caching by incorporating env.pythonLocation into the cache key and removing unnecessary restore cache options. Enhance performance by setting uv as the default venv backend in nox and streamline CI configuration by removing redundant fail-fast strategies.

Enhancements:

Set uv as the default virtual environment backend in nox for improved package installation performance.

CI:

Include env.pythonLocation in the cache key to address cache failures in GitHub Actions.
Remove the generic restore cache option to prevent previous cache issues.
Remove strategy: fail-fast from jobs that do not use a matrix, as it was redundant.

sourcery-ai[bot] commented 2 months ago

🧙 Sourcery has finished reviewing your pull request!

Tips

- Trigger a new Sourcery review by commenting `@sourcery-ai review` on the pull request. - Continue your discussion with Sourcery by replying directly to review comments. - You can change your review settings at any time by accessing your [dashboard](https://app.sourcery.ai): - Enable or disable the Sourcery-generated pull request summary or reviewer's guide; - Change the review language; - You can always [contact us](mailto:support@sourcery.ai) if you have any questions or feedback.

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 96.59%. Comparing base (cafc388) to head (923a530). Report is 1 commits behind head on main.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #3604 +/- ## ========================================== + Coverage 93.86% 96.59% +2.72% ========================================== Files 522 526 +4 Lines 32870 34028 +1158 Branches 3753 5627 +1874 ========================================== + Hits 30854 32869 +2015 + Misses 1719 922 -797 + Partials 297 237 -60 ```

codspeed-hq[bot] commented 2 months ago

CodSpeed Performance Report

Merging #3604 will not alter performance

_{Comparing fix_gh_actions_cache_failures (923a530) with main (cafc388)}

Summary

✅ 15 untouched benchmarks

botberry commented 2 months ago

Apollo Federation Subgraph Compatibility Results

Federation 1 Support Federation 2 Support

`_service`	🟢
`@key (single)`	🟢
`@key (multi)`	🟢
`@key (composite)`	🟢
`repeatable @key`	🟢
`@requires`	🟢
`@provides`	🟢
`federated tracing`	🔲

`@link`	🟢
`@shareable`	🟢
`@tag`	🟢
`@override`	🟢
`@inaccessible`	🟢
`@composeDirective`	🟢
`@interfaceObject`	🟢

Learn more:

bellini666 commented 2 months ago

@sourcery-ai review

botberry commented 2 months ago

Hi, thanks for contributing to Strawberry 🍓!

We noticed that this PR is missing a RELEASE.md file. We use that to automatically do releases here on GitHub and, most importantly, to PyPI!

So as soon as this PR is merged, a release will be made 🚀.

Here's an example of RELEASE.md:

Release type: patch

Description of the changes, ideally with some examples, if adding a new feature.

Release type can be one of patch, minor or major. We use semver, so make sure to pick the appropriate type. If in doubt feel free to ask :)

Here's the tweet text:

🆕 Release (next) is out! Thanks to @_bellini666 for the PR 👏

Get it here 👉 https://strawberry.rocks/release/(next)

patrick91 commented 2 months ago

@bellini666 looks like it is an issue with the latest version of starlette 🤔

strawberry-graphql / strawberry