Remove starlite - Githubissues

patrick91 commented 2 months ago

Starlite has been deprecated for a while, and I was having some errors on another PR, so I decided to finally remove it 😊

Summary by Sourcery

Remove the deprecated Starlite integration from the project, replacing it with Litestar where applicable, and update documentation to reflect these changes.

Enhancements:

Remove Starlite integration from the codebase due to its deprecation, replacing it with Litestar where necessary.

Documentation:

Delete the Starlite integration documentation and add a release note advising users to migrate to Litestar or another alternative.

Chores:

Delete all Starlite-related files and tests, including controllers, handlers, and test cases.

botberry commented 2 months ago

Apollo Federation Subgraph Compatibility Results

Federation 1 Support Federation 2 Support

`_service`	🟢
`@key (single)`	🟢
`@key (multi)`	🟢
`@key (composite)`	🟢
`repeatable @key`	🟢
`@requires`	🟢
`@provides`	🟢
`federated tracing`	🔲

`@link`	🟢
`@shareable`	🟢
`@tag`	🟢
`@override`	🟢
`@inaccessible`	🟢
`@composeDirective`	🟢
`@interfaceObject`	🟢

Learn more:

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 96.82%. Comparing base (26fa597) to head (cc98fd9). Report is 1 commits behind head on main.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #3609 +/- ## ========================================== + Coverage 96.59% 96.82% +0.23% ========================================== Files 526 514 -12 Lines 34028 33293 -735 Branches 5627 5522 -105 ========================================== - Hits 32869 32236 -633 + Misses 922 833 -89 + Partials 237 224 -13 ```

sourcery-ai[bot] commented 2 months ago

Reviewer's Guide by Sourcery

This pull request removes the Starlite integration from the project. Starlite has been deprecated, and the changes involve removing Starlite-related code, imports, and test files. The PR also updates the test configuration and adds a release note.

File-Level Changes

Change	Details	Files
Removal of Starlite from test configurations	Removed 'starlite' from the list of test markers Removed Starlite-specific test skip condition Updated imports from 'starlite' to 'litestar' in test client fixtures	`tests/conftest.py` `tests/litestar/conftest.py`
Removal of Starlite from HTTP client classes	Removed 'StarliteHttpClient' from the list of HTTP client classes Removed Starlite-specific exception handling	`tests/http/conftest.py` `tests/websockets/conftest.py`
Removal of Starlite-specific file handling	Removed code block for handling Starlite UploadFile	`tests/views/schema.py`
Updates to build and test configuration	Removed 'starlite' from the list of integrations Removed Starlite-specific test session configuration	`noxfile.py`
Addition of release notes	Added RELEASE.md file with information about Starlite removal	`RELEASE.md`
Deletion of Starlite-related files	Removed Starlite controller file Removed Starlite-specific test files Removed Starlite documentation Removed Starlite handlers Removed Starlite integration files	`strawberry/starlite/controller.py` `tests/http/clients/starlite.py` `tests/starlite/test_context.py` `tests/starlite/schema.py` `docs/integrations/starlite.md` `tests/starlite/test_websockets.py` `strawberry/starlite/handlers/graphql_ws_handler.py` `tests/starlite/test_response_headers.py` `strawberry/starlite/handlers/graphql_transport_ws_handler.py` `tests/starlite/test_response_status.py` `tests/starlite/app.py` `tests/starlite/conftest.py` `strawberry/starlite/__init__.py`

Tips

- Trigger a new Sourcery review by commenting `@sourcery-ai review` on the pull request. - Continue your discussion with Sourcery by replying directly to review comments. - You can change your review settings at any time by accessing your [dashboard](https://app.sourcery.ai): - Enable or disable the Sourcery-generated pull request summary or reviewer's guide; - Change the review language; - You can always [contact us](mailto:support@sourcery.ai) if you have any questions or feedback.

botberry commented 2 months ago

Thanks for adding the RELEASE.md file!

Here's a preview of the changelog:

This release removes the integration of Starlite, as it has been deprecated since 11 May 2024.

If you are using Starlite, please consider migrating to Litestar (https://litestar.dev) or another alternative.

Here's the tweet text:

🆕 Release (next) is out! Thanks to @patrick91 for the PR 👏

Get it here 👉 https://strawberry.rocks/release/(next)

codspeed-hq[bot] commented 2 months ago

CodSpeed Performance Report

Merging #3609 will not alter performance

_{Comparing feature/remove-starlite (cc98fd9) with main (26fa597)}

Summary

✅ 15 untouched benchmarks

strawberry-graphql / strawberry

Remove starlite #3609