Closed szokeasaurusrex closed 4 weeks ago
I am not sure how to add a test here/whether it is needed
This pull request fixes a Python 3.8 type error by modifying a type hint in the strawberry/http/async_base_view.py
file. The change involves making the type hint a string to prevent it from being evaluated at runtime, which was causing a TypeError
in Python 3.8.
Change | Details | Files |
---|---|---|
Modified type hint to prevent runtime evaluation |
|
strawberry/http/async_base_view.py |
Thanks for adding the RELEASE.md
file!
Here's a preview of the changelog:
This release fixes a TypeError on Python 3.8 due to us using a
asyncio.Queue[Tuple[bool, Any]](1)
instead of asyncio.Queue(1)
.
Here's the tweet text:
🆕 Release (next) is out! Thanks to Daniel Szoke for the PR 👏
Get it here 👉 https://strawberry.rocks/release/(next)
Hi, thanks for contributing to Strawberry 🍓!
We noticed that this PR is missing a RELEASE.md
file. We use that to automatically do releases here on GitHub and, most importantly, to PyPI!
So as soon as this PR is merged, a release will be made 🚀.
Here's an example of RELEASE.md
:
Release type: patch
Description of the changes, ideally with some examples, if adding a new feature.
Release type can be one of patch, minor or major. We use semver, so make sure to pick the appropriate type. If in doubt feel free to ask :)
Here's the tweet text:
🆕 Release (next) is out! Thanks to Daniel Szoke for the PR 👏
Get it here 👉 https://strawberry.rocks/release/(next)
Comparing szokeasaurusrex:main
(022b6ef) with main
(54b8a49)
✅ 15
untouched benchmarks
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 96.79%. Comparing base (
54b8a49
) to head (022b6ef
). Report is 2 commits behind head on main.
@szokeasaurusrex thanks! I wonder why this wasn't caught in our CI 🤔
I'll add a release and ship this 😊
Thanks for contributing to Strawberry! 🎉 You've been invited to join the Strawberry GraphQL organisation 😊
You can also request a free sticker by filling this form: https://forms.gle/dmnfQUPoY5gZbVT67
And don't forget to join our discord server: https://strawberry.rocks/discord 🔥
Description
Make type hint a string so that it is not evaluated at runtime, where it would cause a
TypeError
in Python 3.8.Types of Changes
Issues Fixed or Closed by This PR
Checklist
Summary by Sourcery
Fix a type error in Python 3.8 by converting a type hint to a string in the async_base_view.py file.
Bug Fixes: