strawlab / MultiCamSelfCal

multiple camera self calibration Toolbox
http://cmp.felk.cvut.cz/~svoboda/SelfCal/
196 stars 77 forks source link

error: 'isfolder' undefined #12

Open florisvb opened 5 months ago

florisvb commented 5 months ago

I am getting this error when running octave gocal.m with my own data, as well as all three of the test datasets. Any idea what is happening?

caveman@RiffellCave1:~/big_tunnel_calibration_test/latest/MultiCamSelfCal/MultiCamSelfCal$ octave gocal.m --config=/home/caveman/big_tunnel_calibration_test/latest/MultiCamSelfCal/strawlab/test-data/caldata20130726_122220 warning: function ../CalTechCal/quiver.m shadows a core library function warning: called from gocal.m at line 23 column 1 arg = --config=/home/caveman/big_tunnel_calibration_test/latest/MultiCamSelfCal/strawlab/test-data/caldata20130726_122220 error: 'isfolder' undefined near line 14 column 4 error: called from read_generic_configuration at line 14 column 1 read_configuration at line 43 column 8 gocal.m at line 26 column 8

I do not get this error on an older commit: 94e0bb2a479546d0af6bf29a3681aae7be08daf9

slivingston commented 5 months ago

Which version of octave do you have? The function isfolder was added relatively recently (https://github.com/gnu-octave/octave/commit/7bbad5a643fc84dd5797d73660c1ee4e0b88e2c9).

florisvb commented 5 months ago

I'll double check tomorrow.. but probably an older version, as I tested it on a machine running ubuntu 18.. I should be able to share some more info later this week, but there seem to be some issues with the newer version of MCSC and/or newer versions of octave.

We are able to get things to converge on old versions of MCSC on ubuntu 18 machines, but the same calibration datasets really struggle to make any progress on ubuntu 20 and the latest MCSC.

On Tue, May 21, 2024 at 7:59 PM Scott C. Livingston < @.***> wrote:

Which version of octave do you have? The function isfolder was added relatively recently @.*** https://github.com/gnu-octave/octave/commit/7bbad5a643fc84dd5797d73660c1ee4e0b88e2c9 ).

— Reply to this email directly, view it on GitHub https://github.com/strawlab/MultiCamSelfCal/issues/12#issuecomment-2123779604, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAB4EPH2UMGDRJXQTCTDUM3ZDQCXXAVCNFSM6AAAAABICCGHWOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMRTG43TSNRQGQ . You are receiving this because you authored the thread.Message ID: @.***>

-- Floris van Breugel | http://www.florisvanbreugel.com Assistant Professor of Mechanical Engineering & Graduate Program for Neuroscience University of Nevada, Reno

Wildlife and Landscape Photography Galleries: http://www.ArtInNaturePhotography.com/ Blog: http://www.ArtInNaturePhotography.com/wordpress/

astraw commented 5 months ago

The specific lines with isfolder were introduced here https://github.com/strawlab/MultiCamSelfCal/commit/9a089aff to fix a deprecation warning. The change should be trivial for you to revert, however. Hopefully there won't be other incompatibilities.

If you have a dataset where the calibration works with Ubuntu 18 and not on Ubuntu 20, that would be valuable to add here as a test to ensure we don't have regressions in the future. (Fixing deprecation warnings as time marches forward I do not consider a regression.)

I would appreciate it if you keep this issue updated with your findings, as I would certainly like to avoid regressions in convergence or other computational aspects.