search

straydogstudio / film_roll

A lightweight jQuery carousel that centers one item at a time on the page.
MIT License
207 stars 60 forks source link

IE6/7 support #1

Closed PlayerYK closed 10 years ago

PlayerYK commented 11 years ago

This is really great lib, this is the effect I want long time ago. thank you.

But have you thought to support IE 6/7, it is broken now on IE6/7.

straydogstudio commented 11 years ago

I'm not surprised it is broken on IE6/7. I got it working on IE8, but I'm not likely to do the work for what is before that. I might do it if you get me a canned set of files as an example.

Is your html composed of a container div with child divs? It would be worth trying that if it isn't. The default browser CSS can interfere depending on the markup.

I expect it is a CSS issue. Do you have time/ability to figure it out? I would paste the default CSS into a separate file, and pass in the no_css: true option to FilmRoll, and then change the CSS until it worked right. If you do that, be sure to get that to me, and I'll be sure to add it to the Readme at least, if not add it to the code.

straydogstudio commented 11 years ago

@ikamal I've seen stats that show how much XP is still used in China. Is IE6/7 still really common? Is there a difficulty in moving to IE8? Just curious.

If you can't find a fix, get me a set of files to test with (so I can see exactly what you are seeing) and I'll spend some time on it. You could make a github repo of it. Hopefully it is an easy fix.

PlayerYK commented 11 years ago

Thank you for your reply Noel, I will show you a demo tomorrow, I believe this is not just a css issue.

here is the browsers report in china mainland: http://mta.qq.com/mta/operation/wp-content/uploads/2013/08/4-2.png

PlayerYK commented 11 years ago

browser engine: http://mta.qq.com/mta/operation/wp-content/uploads/2013/08/4-3.png

OS: http://mta.qq.com/mta/operation/wp-content/uploads/2013/08/4-4.png

PlayerYK commented 11 years ago

Please check this page in IE's IE7 mode http://straydogstudio.github.io/film_roll/

&lt div class="film_roll_shuttle" style="width: 100000px; height: 560px; left: -249350px;" sizzle-1380290119703="[object Object]">

straydogstudio commented 11 years ago

@ikamal I've posted an initial fix. It isn't quite centering right, but at least the scroll works as expected.

Try it out and let me know if it works for IE6.

http://straydogstudio.github.io/film_roll/

PlayerYK commented 11 years ago

Great job! it works prefect in IE7. in IE 6 all the scroll effect works fine, just a little position errors, the second, and third scroll's arrow shows out of the box, but I think this is just css issue.

Thank you.