search

straydogstudio / film_roll

A lightweight jQuery carousel that centers one item at a time on the page.
MIT License
207 stars 60 forks source link

Fix endless while if one image #16

Closed p41nfu11 closed 10 years ago

p41nfu11 commented 10 years ago

Fix issue that makes browser freeze up if the film roll is loaded with only one image and moveToIndex is called twice.

(children.length == 1 => the while loop never exits)

straydogstudio commented 10 years ago

Thanks for the pull request. I'm in the middle of some changes in this section, so I can't merge it yet.

straydogstudio commented 10 years ago

Do you have a use case where we would want to do anything if there is one child? I'm thinking it makes sense to simply do the same thing if the carousel is narrower than its wrapper; nothing is moved, but the new active child gets the active class. A one child carousel would always have an active class.

But I could see something else might make more sense.