search

strayrobots / 3d-annotation-tool

A graphical user interface to annotate point clouds and 3D data.
MIT License
78 stars 8 forks source link

Window resize #11

Closed kekeblom closed 3 years ago

kekeblom commented 3 years ago

Implements window window resizing.

Merge #10 first.

hietalajulius commented 3 years ago

Hmm I'm getting a segfault for some reason, I need to look further into it. Could not spot anything alarming at least from the bgfx debug logging:

$ ./main /home/clothmanip/open3d/datasets/box2/realsense
...
/home/clothmanip/stray/LabelStudio/submodules/bgfx/bgfx/src/bgfx.cpp (3463): BGFX Init complete.
Done building bounding volume hierarchy.
Segmentation fault (core dumped)
kekeblom commented 3 years ago

Could be related to the viewWillAppear method not being called. Or just make sure you rerun cmake and rebuild. I'll take a closer look later with a clean build.

kekeblom commented 3 years ago

Can't reproduce on my system even with a fresh build. Maybe try running it with gdb and run the backtrace command after the crash to see the stacktrace.

hietalajulius commented 3 years ago

Looks like this was due to loading existing keypoints from json before the mesh view was created:

(gdb) backtrace
#0  views::MeshView::addObject (this=0x0, obj=std::shared_ptr<views::MeshDrawable> (use count 2, weak count 0) = {...})
    at /home/clothmanip/stray/LabelStudio/src/views/mesh_view.cc:72
#1  0x000055555557190c in commands::AddKeypointCommand::execute(StudioViewController&, SceneModel&) () at /usr/include/c++/9/ext/atomicity.h:96
#2  0x000055555558c4ca in LabelStudio::loadState() () at /home/clothmanip/stray/LabelStudio/src/label_studio.cc:99
#3  0x000055555558c843 in LabelStudio::LabelStudio(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) ()
    at /home/clothmanip/stray/LabelStudio/src/label_studio.cc:12

Moved calling loadState after viewWillAppear: https://github.com/StrayRobots/LabelStudio/pull/11/commits/ccdbb114efd50b4af85dc3e26c7985cde5582c5e Wdyt? :+1:

kekeblom commented 3 years ago

Ah, makes sense.