search

strayrobots / 3d-annotation-tool

A graphical user interface to annotate point clouds and 3D data.
MIT License
78 stars 8 forks source link

View refactor #17

Closed kekeblom closed 3 years ago

kekeblom commented 3 years ago

Removed a bunch of state from the views. Made the tools views as well.

Turned out to be less code for the same amount of functionality too.

hietalajulius commented 3 years ago

Whoa, what an effort, thanks! 🔥 I'll dive into this tomorrow 👍

hietalajulius commented 3 years ago

https://user-images.githubusercontent.com/4254623/116912811-61ea3700-ac51-11eb-90f4-43569575f957.mp4

Something funny is happening with the bunny fixture, not able to zoom/move the scene :thinking: The box scenes are ok :+1:

hietalajulius commented 3 years ago

bunny.mp4 Something funny is happening with the bunny fixture, not able to zoom/move the scene The box scenes are ok

Screenshot from 2021-05-03 21-18-16 Ok looks like it is happening when there are no keypoints. I wonder if the 

 if (!keypoints.empty()) {
      setCameraTransform(context);
      ...

in annotation_view.h has something to do with it :thinking: Yet to dive deeper to say for certain

kekeblom commented 3 years ago

Good catch. Did not cross my mind that it would be relying on the transform set elsewhere. I now set it for each render call. We can optimize that if it becomes a problem to reset it in different places.

hietalajulius commented 3 years ago

Good catch. Did not cross my mind that it would be relying on the transform set elsewhere. I now set it for each render call. We can optimize that if it becomes a problem to reset it in different places.

Nice! Yeah I guess the setCameraTransform could also be called in render of StudioViewController but tomato tomato :D