strayrobots / 3d-annotation-tool

A graphical user interface to annotate point clouds and 3D data.
MIT License
76 stars 8 forks source link

Bbox #18

Closed kekeblom closed 3 years ago

kekeblom commented 3 years ago

Implements bounding boxes.

image

This changes the annotation format and file. It used to be scene/keypoints.json it is now scene/annotations.json and it includes fields for keypoints and bounding boxes.

hietalajulius commented 3 years ago

Implements bounding boxes.

image

This changes the annotation format and file. It used to be scene/keypoints.json it is now scene/annotations.json and it includes fields for keypoints and bounding boxes.

Whoa, super nice! :fire: Will take a look tonight + hook up with the 2d bounding box script :+1:

hietalajulius commented 3 years ago

Screenshot from 2021-05-09 18-47-29 Hmm seems like the box is not appearing on my machine for some reason (did a fresh build), let's see what's up :thinking:

Edit: looks like it was due to u_scale being vec3 in the shader even though in code it's vec4, I can push the change :+1:

hietalajulius commented 3 years ago

Edit: looks like it was due to u_scale being vec3 in the shader even though in code it's vec4, I can push the change

Pushed two commits to fix above + save print: https://github.com/StrayRobots/LabelStudio/pull/18/commits/7bc7f065d6c271349edccd4bbef5aa6fc6399540 https://github.com/StrayRobots/LabelStudio/pull/18/commits/d292b2a54b147c3ebca7ce6784a630a0e709efe5

Let's also run formatting before merge, did not want to push that here for a huge diff during review :D