Closed hietalajulius closed 2 years ago
Looks ok to me on an initial review. Maybe moving some of the stuff that is common with the point cloud controller and studio view controller to a helper class could be nice.
There are quite a few warnings when compiling from scratch, which might be nice to fix.
I'll try this out and contribute some fixes.
Adds a new
pointcloud
app./pointcloud <path-to-the-directory-containing-the-ply-files>
<path-to-the-directory-containing-the-ply-files>
Studio
(direct copy of previousLabelStudio
)StudioViewController
/PointCloudViewController
) as a template argumentStudioViewController
more or less unchanged (old studio stuff)PointCloudViewController
(point cloud studio stuff)StudioViewController
, some of this can be moved to a base class in the futureSceneModel
is only concerned about the keypoints/boxes/rects present in studio, things such as image paths/camera intrinsics/other "Stray scene" specific things moved to the controller (for now)SceneModel
really was not feasible since being able to use subclasses likeStraySceneModel
("Stray scene" specific) andPointCloudSceneModel
(point clouds specific) would require quite big refactoring sinceSceneModel
is used quite broadly.TODOs left:
tab
<path-to-the-directory-containing-the-ply-files>/annotations.json
for every cloud