search

strazto / videoduplicatefinder

NOT MAINTAINED - Use https://github.com/0x90d/videoduplicatefinder -
15 stars 3 forks source link

[Linux.Gui]Bug: JPGs & MKVs are matching, and thumbnails don't always work #28

Open vsolina2 opened 3 years ago

vsolina2 commented 3 years ago

videoduplicatefinder version

2.1.0

Operating System

Linux

Client Type

Cross platform GUI (Versions >= 2.1.0)

Describe the bug

Not creating the thumbnails result every files is 100% match in jpg and mkv

Expected behaviour

thumbnails should be created maybe add some checking on time length of video

strazto commented 3 years ago

To get this straight - there's two things going on here, right?

  1. (More serious) sometimes it seems that MKVs and JPGs are incorrectly matches
  2. Thumbnails are not being created sometimes

Does 2. only occur when in groups with mismatched MKVs and JPGs?

vsolina2 commented 3 years ago

Correct all files are matched regardless of size format Thumbnails are not created regardless of settings/choices

  1. occurs all the time

On 28 Jul 2021, at 12:14 pm, Matthew Strasiotto @.***> wrote:

To get this straight - there's two things going on here, right?

(More serious) sometimes it seems that MKVs and JPGs are incorrectly matches Thumbnails are not being created sometimes Does 2. only occur when in groups with mismatched MKVs and JPGs?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/matthewstrasiotto/videoduplicatefinder/issues/28#issuecomment-887956522, or unsubscribe https://github.com/notifications/unsubscribe-auth/APORO2DAOMA2ILN3PREVUSTTZ5RY5ANCNFSM5A2CCBOQ.

strazto commented 3 years ago

Would you be able to provide a set of files I can reproduce 1. or both with please?

strazto commented 3 years ago

Sounds like the MKV/JPG thing is related to https://github.com/0x90d/videoduplicatefinder/issues/137 - The MKV container format can contain both images & videos, and sometimes the embedded image is used for comparison (which is a bug)

strazto commented 3 years ago
  1. May be a dependency issue, please confirm that you have libgdiplus installed
vsolina2 commented 3 years ago

libgdiplus is installed it also occurs with Mp4 avi all are regarded as duplicates

On 28 Jul 2021, at 12:51 pm, Matthew Strasiotto @.***> wrote:

May be a dependency issue, please confirm that you have libgdiplus installed — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/matthewstrasiotto/videoduplicatefinder/issues/28#issuecomment-887968500, or unsubscribe https://github.com/notifications/unsubscribe-auth/APORO2B225IFYWK47WTPR2DTZ5WCLANCNFSM5A2CCBOQ.

strazto commented 3 years ago

Okay, I'd love if you'd be able to share the files that trigger either problem, is that posssible? Happy to provide a drive link for you to drop them in if it helps

strazto commented 3 years ago

@vsolina2 I'm going to have to delete those comments, as I can't condone sharing links to piracy sites here

strazto commented 3 years ago

that's okay though - I'll look into this

vsolina2 commented 3 years ago

No problem I thought that would happen but at least you know where to find files for testing unfortunately there isn’t a good dataset for video like there is for images https://opensource.google/projects/open-images-dataset and the datasets with video are not as suitable for this task as most are designed for machine learning https://research.google/tools/datasets/ https://www.kaggle.com/tags/video-data https://gitlab.kitware.com/viratdata/viratannotations

we could make a dataset by taking several hires videos and producing a number of files in various format and resolutions for first cut testing

On 28 Jul 2021, at 5:11 pm, Matthew Strasiotto @.***> wrote:

that's okay though - I'll look into this

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/matthewstrasiotto/videoduplicatefinder/issues/28#issuecomment-888070348, or unsubscribe https://github.com/notifications/unsubscribe-auth/APORO2GZUO2X47D47P4G3M3TZ6URTANCNFSM5A2CCBOQ.

strazto commented 3 years ago

That's okay - I was hoping for specific examples that reproduce the bug because in my usage I haven't been able to reproduce it.

strazto commented 3 years ago

We call this a MWE, minimal working example, or sometimes a reproducible example https://stackoverflow.com/help/minimal-reproducible-example

This would be very helpful in isolating the cause of these bugs.

jremar98 commented 3 years ago

Hello @matthewstrasiotto ! Thanks for updating this program and keeping it going! I've been having the same problems as vsolina2 :( I shot 4 videos on my iPhone just of some oscilloscope screens (so no issues with copyright) that reproduce the issue and would be happy to post them to your drive if you give me a link/instructions!

I'm running VideoDuplicateFinder 2.10 GUI on Kubuntu 20.04.2 LTS and have verified that I have libgdiplus installed (version 6.0.4+dfsg-2) and ffmpeg installed (version 7:4.2.4-1ubuntu0.1).

I've also attached some screenshots of the unique videos reported under the same duplicate group to the comment (I tested with both .mp4 versions and .mov versions separately, and the two directories combined)

Please let me know if you need any additional info! I'm quite new to the GitHub scene, so I'm not fluent on best practices for bug reporting:) MOV_and_MP4_Duplicate_Group MOV_Duplicate_Group MP4_Duplicate_Group

strazto commented 3 years ago

@jremar98 thank you! Wonderful I'll follow that up in the morning

strazto commented 3 years ago

@jremar98 , here's a drive folder - https://drive.google.com/drive/folders/1sZoBSx_Hpq22-MsNTfsUtaLiaa1tNJSk?usp=sharing you'll need to request access

(PS - pretend it's the next morning 🙃)

jremar98 commented 3 years ago

@matthewstrasiotto Thank You! I uploaded the folder of videos along with an html of one of the results. Also, in case it helps, this issue occurs when both running from my home user as well as running as sudo (using the sudo su command).

Please let me know if you need any more info!

strazto commented 3 years ago

@matthewstrasiotto Also, in case it helps, this issue occurs when both running from my home user as well as running as sudo (using the sudo su command).

Thank you - That might help, though I'd be surprised. I do recommend that you try to avoid using superuser for this kind of application, since most likely your user account should have all of its permissions already set up.

Also - it looks like the author of the upstream is active again, so depending on their level of involvement & commitment, I may be rebasing this project onto the upstream to hopefully maintain parity & consolidate our work.

Edit From comparing the current HEAD to the last release tag, looks like most of what 0x90d has done is remove the windows only GUI, rename the cross platform GUI, and rename the Engine component to Core. https://github.com/0x90d/videoduplicatefinder/compare/c191901...master

It looks like there are further changes besides renaming stuff, but I haven't distinguished them quickly.

I'll test build the upstream, probably upload an ad-hoc release to my google drive & link it somewhere on their repo, and then I'll figure out how/what I can rebase onto the upstream