search

strazzere / 010Editor-stuff

A collection of 010 Editor specific stuff
402 stars 158 forks source link

Short Data Descriptors #12

Closed reox closed 7 years ago

reox commented 8 years ago

Hi! As I found out, it is possible that data descriptors do not have a signature. See https://pkware.cachefly.net/webdocs/casestudies/APPNOTE.TXT

4.3.9.3 Although not originally assigned a signature, the value 0x08074b50 has commonly been adopted as a signature value for the data descriptor record. Implementers should be aware that ZIP files may be encountered with or without this signature marking data descriptors and SHOULD account for either case when reading ZIP files to ensure compatibility.

I added an extra check for that and the template works now with files that have this signature not set.

strazzere commented 8 years ago

Added a few comments, can we remove the printf/debug statements? After that I'll happily accept all the other changes, thank you!

reox commented 7 years ago

Hey, sorry i saw now this is over a year old....

Sure, just remove it. I also saw that the code is mixed tabs/spaces. What is the code convention here? I could fix that as well then...

ty!

strazzere commented 7 years ago

Thanks for taking a look at that @reox :D