search

streadway / amqp

Go client for AMQP 0.9.1
http://godoc.org/github.com/streadway/amqp
BSD 2-Clause "Simplified" License
4.88k stars 621 forks source link

No lock in reject #374

Closed AgrimPrasad closed 5 years ago

AgrimPrasad commented 5 years ago

https://github.com/streadway/amqp/issues/318 and https://github.com/streadway/amqp/issues/327 added locks for ack/nack but there's still no lock for reject: https://github.com/streadway/amqp/blob/27835f1a64e97101d95306211f03c0620ffa295d/channel.go#L1582-L1587

Is there any reason for this or is it okay if I create a PR to fix this?

michaelklishin commented 5 years ago

No particular reason. Please submit a PR.

AgrimPrasad commented 5 years ago

Sure, created #375

michaelklishin commented 5 years ago

Addressed in #375, thank you @AgrimPrasad.