Refined thread-safety for MemoryManager - Githubissues

stream-labs / obs-studio-node

libOBS (OBS Studio) for Node.Js, Electron and similar tools

GNU General Public License v2.0

606 stars 99 forks source link

Refined thread-safety for MemoryManager #1328

Closed avoitenko-logitech closed 1 year ago

avoitenko-logitech commented 1 year ago

Description

Refined thread-safety model for MemoryManager.
Fixed multiple data races + 1 undefined behavior.
Core logic and algorithms left unchanged, but work with locks and threads was almost completely rewritten.
Additionally made some modern C++ code improvements
Removed watcher as it was unused.

Motivation and Context

An attempt to fix crashes. I'll leave comments with descriptions of problems of the old code.

How Has This Been Tested?

Unit tests + logs analysis

Types of changes

Bug fix (non-breaking change which fixes an issue)
Code cleanup (non-breaking change which makes code smaller or more readable)