search

stream-pi / server

Stream-Pi Server
GNU General Public License v3.0
217 stars 21 forks source link

Improved icons and System Tray Menu Order #72

Closed Thjj closed 3 years ago

Thjj commented 3 years ago

Icon now in 1:1 aspect ratio Added icons in smaller resolution Better order in tray menu (Exit on bottom)

Thjj commented 3 years ago

macos-icon.icns and windows-icon.ico are required for the executable installer binaries.

macos-icon.icns and windows-icon.ico are where they should be. They only have a 1:1 aspect ratio and for windows and macos I added icons in lower resolution.

rnayabed commented 3 years ago

Oops, i just realised that they are not deleted, but reduced in size. Can you enable and run the workflows on your fork, build jpackage binaries and then try out the installer binaries and see whether the icon quality was degraded in windows/mac systems (app icon, and installer icon)?

Thjj commented 3 years ago

Yes, I'm going to try it

rnayabed commented 3 years ago

I forked your fork, into another fork, ran the workflows there, tried it on a Windows 10 VM, and it looks good :+1:

image Old Icon (Left) vs New Icon (Right)

image Old Icon (Top) vs New Icon (Buttom)

image image New Icon (Top) vs Old Icon (Bottom)

Ill try running on a MacOS VM and an Ubuntu VM later today. If you have a MacOS and Ubuntu/RPM based system yourself, please post a similar comparison like this for them.

I run Manjaro, so neither RPM nor DEB work on my system. I tried the zip, the logos looked fine.

Thjj commented 3 years ago

This is what it looks like on the Ubuntu 20.04 VM, and it looks almost the same. Taskbar New Icon (Top) vs Old Icon (Bottom) App browse new App browse old New Icon (Top) vs Old Icon (Bottom)