stream-utils / stream-to-array

[OBSOLUTE] Concatenate a readable stream's data into a single array.
MIT License
100 stars 12 forks source link

Remove bluebird dependency #8

Closed felixfbecker closed 8 years ago

felixfbecker commented 8 years ago

This module depends on both native-or-bluebird and bluebird, but only the former is actually required in code.

jonathanong commented 8 years ago

this was to keep 0.10 support w/o bumping a major version... i don't mind bumping another version and dropping 0.10 support now since it's so old

jonathanong commented 8 years ago

meh minor's fine.

felixfbecker commented 8 years ago

It doesn't matter for me but I stumbled across this and found it odd :)

felixfbecker commented 8 years ago

Shouldn't it be a patch version though?

jonathanong commented 8 years ago

dunno. kind of breaking, kind of a feature, kind of a bug fix. when in doubt, bump minor!

felixfbecker commented 8 years ago

Well native-or-bluebird has was already used, the only change is in package.json ^^