streamdal / plumber

A swiss army knife CLI tool for interacting with Kafka, RabbitMQ and other messaging systems.
https://streamdal.com
MIT License
2.08k stars 71 forks source link

plumber --version is `UNSET` #363

Closed ghost closed 7 months ago

ghost commented 8 months ago

Describe the bug

./plumber --version
UNSET

go.mod sets module github.com/batchcorp/plumber but the Makefile uses -X 'github.com/streamdal/plumber/options.VERSION=${VERSION}'

blinktag commented 8 months ago

We renamed our company from Batch.sh to Streamdal but haven't gotten around to updating all of our source packages yet. Will get working on that shortly. The version should also include the version number like v2.4.0-854d258, but that is currently only set via CI, so we'll work on a solution for that also

blinktag commented 7 months ago

@a-n-n-a-l-e-e this is fixed now. The CI process will inject the version into version.txt and then running the make build commands will pull this version in