search

streamer45 / mattermost-plugin-voice

Mattermost plugin for voice messaging. :microphone: :sound:
MIT License
81 stars 20 forks source link

bugfix: Recorder is not initialized error #21 #24

Closed congpeijun closed 3 years ago

congpeijun commented 3 years ago

21 Fix this error.

streamer45 commented 3 years ago

@congpeijun

Can you share a bit more context on this PR? The linked issue was caused by a bug in the code (now fixed). Were you having issues with the specific command this PR touches instead? I am thinking it shouldn't really matter whether we add the slash or not to the source directory, unless there's a symlink involved, which should not be the case.

congpeijun commented 3 years ago

Hi, @streamer45 When add the slash, the cp command only copy the folders and files in the public folder, but when realy want the whole public folder instead. I check the plugin starter template, and It do this also. https://github.com/mattermost/mattermost-plugin-starter-template/blob/master/Makefile#L106

streamer45 commented 3 years ago

@congpeijun

Thank you for added info and for the PR. I was asking because I cannot reproduce this behaviour on Linux.
The command performs the same action with or without the ending slash. Maybe it's a shell/system related issue.

Out of curiosity, on what operating system are you experiencing this?

congpeijun commented 3 years ago

@streamer45 macOS Big sur. Good news for merging, Thanks!