Remove line-height from unitless props

streamich / nano-css

Distilled CSS-in-JS for gourmet developers

The Unlicense

430 stars 24 forks source link

Remove line-height from unitless props #221

Closed MindaugasVarkalys closed 5 years ago

MindaugasVarkalys commented 5 years ago

line-height is not unitless prop

streamich commented 5 years ago

You are correct that line-height value can have a unit, but it can also be used without a unit. The purpose of unitless addon is to allow developers to use numeric values for properties and px would be added if that property needs a unit.

This would be a breaking change where px would be added to all line-height: number uses. What is the use case for this?

MindaugasVarkalys commented 5 years ago

Okay, sorry, didn't know that